Fix #1152: Renamed Kubernetes RBAC resources to use non-prefixed names and renamed Openshift RBAC resources to prefix with Openshift #1300
Conversation
…s and renamed Openshift RBAC resources to prefix with Openshift
|
Can one of the admins verify this patch? |
|
ok to test |
| ClusterRole authapi.ClusterRole | ||
| ClusterRoleBinding authapi.ClusterRoleBinding | ||
| ClusterRoleBindingList authapi.ClusterRoleBindingList | ||
| SubjectAccessReviewResponse authapi.SubjectAccessReviewResponse |
There was a problem hiding this comment.
Shouldn't we also prefix above RoleBinding classes from authapi with Openshift also?
Role authapi.Role -> OpenshiftRole authapi.Role
RoleList authapi.RoleList -> OpenshiftRoleList authapi.RoleList
....
|
Also run |
|
Oh, good catch with the OpenshiftRole and OpenshiftRoleList! I'll do that and run the license formatter when I get a chance in a couple of hours :) |
|
Looks like an infrastructure failure? Is there a way to kick it off again?
|
|
@traviswinter : Yeah, I restarted job. |
kubernetes-tests/src/test/java/io/fabric8/kubernetes/client/mock/CronJobTest.java
Show resolved
Hide resolved
...tes-client/src/main/resources/META-INF/services/io.fabric8.kubernetes.client.ResourceHandler
Outdated
Show resolved
Hide resolved
|
[merge] |
Not sure if this level of change is what you meant @rohanKanojia but I think it cleans the Kubernetes RBAC references up quite a bit. It does change the client api (eg. rbac().kubernetesClusterRoles() becomes rbac().clusterRoles()) but I believe it would be a little more intuitive.
If those changes are too severe, I can back off the renaming of the methods at least.
Key changes are in generate.go, kube-schema.json and validation-schema.json
Fixes #1152