Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed to use ExecConfig instead of additionalProperties #1333

Merged
merged 2 commits into from
Jan 31, 2019
Merged

Changed to use ExecConfig instead of additionalProperties #1333

merged 2 commits into from
Jan 31, 2019

Conversation

janario
Copy link
Contributor

@janario janario commented Jan 29, 2019 •
edited by rohanKanojia
Loading

Fixes #1332
Fix to use ExecConfig to retrieve credentials

  • using ExecConfig
  • re-enabled test-case

@centos-ci
Copy link

Can one of the admins verify this patch?

@janario janario mentioned this pull request Jan 29, 2019
Closed
@rohanKanojia
Copy link
Member

ok to test

@rohanKanojia rohanKanojia added the changelog missing A line to changelog.md regarding the change is not added label Jan 30, 2019
rohanKanojia
rohanKanojia approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks. Could you please add a line to CHANGELOG regarding this change?

@janario
Copy link
Contributor Author

janario commented Jan 30, 2019

Looks good, Thanks. Could you please add a line to CHANGELOG regarding this change?

Added changelog,

Thanks :)

@rohanKanojia rohanKanojia removed the changelog missing A line to changelog.md regarding the change is not added label Jan 30, 2019
@rohanKanojia
Copy link
Member

[merge]

@fusesource-ci fusesource-ci merged commit b91fa61 into fabric8io:master Jan 31, 2019
@jglick
Copy link
Contributor

jglick commented Feb 5, 2019

Amends #1224 FTR.

@Jeffwan Jeffwan mentioned this pull request Feb 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@janario @centos-ci @rohanKanojia @jglick @oscerd @fusesource-ci