Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the Java generator Maven Plugin able to directly download resources #4697

Merged
merged 4 commits into from
Dec 23, 2022
Merged

Make the Java generator Maven Plugin able to directly download resources #4697

merged 4 commits into from
Dec 23, 2022

Conversation

andreaTP
Copy link
Member

Description

Fix #4622

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@andreaTP
Copy link
Member Author

This is the resulting simplification from this change:
https://github.com/bf2fc6cc711aee1a0c2a/e2e-test-suite/pull/434/files

@andreaTP andreaTP changed the title Fix 4622 Make the Java generator Maven Plugin able to directly download resources Dec 19, 2022
@rohanKanojia
Copy link
Member

@andreaTP : Do you think the sonar report for closing ReadableByteChannel should be addressed?

@andreaTP
Copy link
Member Author

@rohanKanojia sure! Done!

@manusa
Copy link
Member

manusa commented Dec 23, 2022

I'll create a follow-up PR to generalize the remote URL source so that it can be reused from the CLI tool, the Maven plugin, direct API usage, or whatever we build next.

@manusa manusa mentioned this pull request Dec 23, 2022
Closed
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 1bcf0ed into fabric8io:master Dec 23, 2022
@manusa manusa added the changelog missing A line to changelog.md regarding the change is not added label Dec 24, 2022
@manusa manusa removed the changelog missing A line to changelog.md regarding the change is not added label Jan 19, 2023
@manusa manusa added this to the 6.4.0 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohanKanojia rohanKanojia rohanKanojia approved these changes

@oscerd oscerd oscerd approved these changes

@sunix sunix sunix approved these changes

@manusa manusa manusa approved these changes

@shawkins shawkins Awaiting requested review from shawkins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.4.0
Development

Successfully merging this pull request may close these issues.

[java-generator] make the Maven plugin(and CLI?) able to fetch CRDs from URLs
5 participants
@andreaTP @rohanKanojia @manusa @sunix @oscerd