feat: add functionality to multiply Quantity by a scalar value #6230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bachmanity1
requested review from
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
rohanKanojia
approved these changes
Aug 8, 2024
bachmanity1
force-pushed
the
impl-quantity-multiply
branch
from
e6a6a48 to
c1d4806
Compare
manusa
reviewed
Aug 8, 2024
...-generator/kubernetes-model-core/src/main/java/io/fabric8/kubernetes/api/model/Quantity.java
Show resolved
Hide resolved
|
|
can we get this merged? |
Yes, but note that 7.0.0 will take a while to get released. |
manusa
added a commit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Go client has added the ability to multiply a Quantity by a scalar value: kubernetes/kubernetes#117411. I think it would be useful to have this feature in the Java client as well.
Type of change
test, version modification, documentation, etc.)
Checklist