Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: use binaries from GitHub releases in Kube API Tests #6281

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

csviri
Copy link
Contributor

@csviri csviri commented Aug 17, 2024

Description

Fix #6277

Uses new approach approach of storing binaries in GitHub for KubeAPITest. Envtest changed its approach, see: kubernetes-sigs/controller-runtime#2811
So, we must also migrate since the former storage approach will be removed.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes (does not apply)
  • I tested my code in OpenShift (does not apply)

csviri added 3 commits August 17, 2024 11:28
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
Copy link
Contributor Author

csviri commented Aug 17, 2024

closes #6277

csviri added 5 commits August 17, 2024 18:28
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri marked this pull request as ready for review August 17, 2024 18:02
@csviri csviri changed the title improve: use GitHub binary repo for Kube API Tests improve: use binaries from GitHub releases in Kube API Tests Aug 17, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@manusa manusa added this to the 7.0.0 milestone Aug 28, 2024 — with automated-tasks
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit 9194634 into fabric8io:main Aug 28, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeApiTest should use the new approach for binary download
3 participants