Enable configuring of categories in CRD generation #6457
Conversation
MichaelMorrisEst
requested review from
andreaTP,
metacosm,
manusa,
oscerd,
rohanKanojia and
shawkins
as code owners
| @@ -0,0 +1,36 @@ | |||
| /* | |||
| * Copyright (C) 2024 Ericsson Software Technology | |||
There was a problem hiding this comment.
Hi @MichaelMorrisEst
The header/license files cannot be changed.
Is it OK if you fallback to the project template?
If not, I'm afraid we won't be able to merge this PR and discard its content.
There was a problem hiding this comment.
Hi @manusa
I believe I have used the standard Apache 2.0 license verbatim and is identical to the header used in the other files (aside from the company name), so I am not sure what the issue is?
There was a problem hiding this comment.
The company name. Style checks and license checks won't pass unless the header text is identical to the rest.
In case I need to make changes to the template or any of its variables I would need to discuss with Red Hat legal first.
In any case, at most the {owner} name could be changed to something like The Fabric8 Kubernetes Client authors (after their approval).
There was a problem hiding this comment.
I've updated as suggested to allow the PR to proceed, but I do not think this is in keeping with the norms for Apache 2.0 licensed software. Id suggest you should check with Red Hat legal what company name they expect in the case of contributions from companies other than Red Hat. I believe the norm here is the company name of the contributor.
There was a problem hiding this comment.
As far as I've seen in any other community project, especially those owned by foundations, it's rarely the case that the company/companies is/are cited in the license header of a file.
Usually a file is contributed to by many individuals who (in a very healthy project) might work for multiple companies.
The file might end up with multiple copyright owner lines.
In our case, I'm unsure if this might have any additional repercussions, hence having to check with legal first for any changes to the licensing status quo.
The header is kind of useless nonetheless. Most projects are shifting to SPDX license expressions, and we should too.
This is just one of those low priority chores that need to be taken care of but haven't had the time to deal with yet. 😓
MichaelMorrisEst
force-pushed
the
issue-5795
branch
from
292c6c8 to
99a27a4
Compare
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Signed-off-by: MichaelMorris <michael.morris@est.tech>
MichaelMorrisEst
force-pushed
the
issue-5795
branch
from
53e29eb to
ef8dab2
Compare
|
Description
Adds a new annotation
@Categoriesthat enables users of the CRD generator to set categories in the generated CRD.Closes #5795
Type of change
test, version modification, documentation, etc.)
Checklist