Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated ReplaceValueStream class #6650

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Remove deprecated ReplaceValueStream class #6650

merged 2 commits into from
Nov 22, 2024

Conversation

currantino
Copy link
Contributor

@currantino currantino commented Nov 22, 2024 •
edited
Loading

Description

Fixes #6644

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@currantino
Copy link
Contributor Author

currantino commented Nov 22, 2024 •
edited
Loading

@manusa Hello, thank you for restarting failed jobs. Do you have any information on why tests that pass locally occasionally fail in github actions?

@manusa
Copy link
Member

manusa commented Nov 22, 2024

there are a couple of flaky test, for some reason they are more unstable lately.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@manusa manusa marked this pull request as ready for review November 22, 2024 16:50
@manusa manusa added this to the 7.0.0 milestone Nov 22, 2024 — with automated-tasks
manusa
manusa approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit b53f691 into fabric8io:main Nov 22, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@oscerd oscerd Awaiting requested review from oscerd oscerd is a code owner

@rohanKanojia rohanKanojia Awaiting requested review from rohanKanojia rohanKanojia is a code owner

@shawkins shawkins Awaiting requested review from shawkins shawkins is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated ReplaceValueStream class
2 participants
@currantino @manusa