Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support removing ResourceEventHandler for informers #6655

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

csviri
Copy link
Contributor

@csviri csviri commented Nov 25, 2024

Description

Fixes #6501

  • feat: make it possible to remove event handler from informers

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@csviri csviri changed the title Ability to remove ResourceEventHandler from informer. Support removing ResourceEventHandler for informers Nov 25, 2024
@csviri
Copy link
Contributor Author

csviri commented Nov 25, 2024

fixes #6501

@csviri csviri force-pushed the remove-event-handler2 branch from 0e9e79c to e2f0ef4 Compare November 25, 2024 14:15
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri csviri force-pushed the remove-event-handler2 branch from e2f0ef4 to ade36c0 Compare November 26, 2024 10:59
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@csviri
Copy link
Contributor Author

csviri commented Nov 26, 2024

@manusa @shawkins the build fail seems to be unrelated. Coverage is 0% since the tests are in different module, pls let me know if I need to polish something on this. thank you!

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa added this to the 7.0.0 milestone Nov 26, 2024 — with automated-tasks
Copy link
Contributor

@shawkins shawkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @csviri

@manusa manusa merged commit 5aa3d9b into fabric8io:main Nov 27, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "RemoveEventHandler" from informers
3 participants