Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(crd-generator): approval test for default double #6670

Merged
merged 1 commit into from
Nov 28, 2024
Merged

test(crd-generator): approval test for default double #6670

merged 1 commit into from
Nov 28, 2024

Conversation

manusa
Copy link
Member

@manusa manusa commented Nov 28, 2024 •
edited
Loading

Description

@andreaTP FYI and for your peace of mind ;)

Relates to:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
test(crd-generator): approval test for default double
4569b06 
Signed-off-by: Marc Nuri <marc@marcnuri.com>
andreaTP
andreaTP approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@andreaTP andreaTP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the late review 😓

@manusa
Copy link
Member Author

manusa commented Nov 28, 2024

Thanks! Sorry for the late review 😓

No worries, I'm kind of in a rush now. I really want to get done with v7.0.0

Maybe we can have a quick sync call later today

@manusa manusa mentioned this pull request Nov 28, 2024
Merged
11 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@manusa manusa added this to the 7.0.0 milestone Nov 28, 2024 — with automated-tasks
@manusa manusa merged commit 70b2128 into fabric8io:main Nov 28, 2024
20 checks passed
@manusa manusa deleted the test/crd-generator-default-double branch November 28, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreaTP andreaTP andreaTP approved these changes

@metacosm metacosm Awaiting requested review from metacosm metacosm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@manusa @andreaTP