fix(): filename is truncated by busboy

fabricjs · Sep 11, 2022 · 1672b59 · 1672b59
1 parent b4af967
commit 1672b59
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/test/GoldensServer.js b/test/GoldensServer.js
@@ -49,8 +49,8 @@ function startGoldensServer() {
                 res.end(JSON.stringify({ exists: fs.existsSync(goldenPath) }));
             }
             else if (req.method.toUpperCase() === 'POST') {
-                const { files: [{ rawData, filename }] } = await parseRequest(req);
-                const goldenPath = path.resolve(wd, 'test', 'visual', 'golden', filename);
+                const { files: [{ rawData }], fields: { filename } } = await parseRequest(req);
+                const goldenPath = path.resolve(wd, 'test', 'visual', 'golden', filename.split('/golden/')[1]);
                 console.log(chalk.gray('[info]'), `creating golden ${path.relative(wd, goldenPath)}`);
                 fs.writeFileSync(goldenPath, rawData, { encoding: 'binary' });
                 res.end();

diff --git a/test/lib/visualTestLoop.js b/test/lib/visualTestLoop.js
@@ -70,24 +70,25 @@
     }
     else if (original) {
       original.toBlob(blob => {
-        const formData = new FormData();
+        const formData = new FormData();        
         formData.append('file', blob, filename);
+        formData.append('filename', filename);
         const request = new XMLHttpRequest();
         request.open('POST', '/goldens', true);
         request.send(formData);
       }, 'image/png');
     }
   }
 
-  function getImage(filename, original, callback) {
+  async function getImage(filename, original, callback) {
     if (fabric.isLikelyNode && original) {
       var plainFileName = filename.replace('file://', '');
       if (!fs.existsSync(plainFileName)) {
         generateGolden(filename, original);
       }
     }
     else if (original) {
-      fetch(`/goldens/${filename}`, { method: 'GET' })
+      await fetch(`/goldens/${filename}`, { method: 'GET' })
         .then(res => res.json())
         .then(res => {
           !res.exists && generateGolden(filename, original);
@@ -156,7 +157,7 @@
           canvas.height = height;
           var ctx = canvas.getContext('2d');
           var output = ctx.getImageData(0, 0, width, height);
-          getImage(getGoldeName(golden), renderedCanvas, function(goldenImage) {
+          getImage(getGoldeName(golden), renderedCanvas, function (goldenImage) {
             ctx.drawImage(goldenImage, 0, 0);
             visualCallback.addArguments({
               enabled: true,