Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize filters work wrong, changing only scaleY (down) or scaleX (up) causes wrong ratio and undesired padding #6729

Closed
rdsn opened this issue Dec 15, 2020 · 3 comments · Fixed by #6778
Labels
stale Issue marked as stale by the stale bot

Comments

@rdsn
Copy link

rdsn commented Dec 15, 2020

Version

4.2.0

Test Case

http://fabricjs.com/lanczos-webgl

Information about environment

Any browser

Steps to reproduce

You can see this behavior on http://fabricjs.com/lanczos-webgl when you try to scale image up by dragging only horizontal handles or scale down by dragging vertical handles

Expected Behavior

Image fills the whole selection box

Actual Behavior

Some strange padding appears under the image its selection box

Also it is not clear why there are scaleX and scaleY instead of just scale, it is not clear what is the use case for having 2 and docs don't say anything about that.

@stale
Copy link

stale bot commented Dec 29, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Dec 29, 2020
@asturur
Copy link
Member

asturur commented Jan 3, 2021

thank you there was an error in plain sight: #6778

@stale stale bot removed the stale Issue marked as stale by the stale bot label Jan 3, 2021
@stale
Copy link

stale bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jan 17, 2021
@rdsn rdsn closed this as completed Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue marked as stale by the stale bot
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants