Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fabric.Image): fix wrong scaling value for the y axis in renderFill #6778

Merged
merged 3 commits into from
Feb 8, 2021

Conversation

asturur
Copy link
Member

@asturur asturur commented Jan 3, 2021

Probably a copy-paste error, we were using scaleX in place of scaleY in a place.

close #6729

@stale
Copy link

stale bot commented Jan 17, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue marked as stale by the stale bot label Jan 17, 2021
@stale stale bot closed this Jan 25, 2021
@asturur asturur reopened this Feb 7, 2021
@stale stale bot removed the stale Issue marked as stale by the stale bot label Feb 7, 2021
@asturur
Copy link
Member Author

asturur commented Feb 7, 2021

Needs a small test.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2021

Code Coverage Summary

> fabric@4.3.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.7 |     76.9 |    85.6 |   82.46 |                                               
 fabric.js |    82.7 |     76.9 |    85.6 |   82.46 | ...,29558,29683,29763-29828,29951,30050,30267 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2021

Code Coverage Summary

> fabric@4.3.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |    82.7 |    76.91 |    85.6 |   82.46 |                                               
 fabric.js |    82.7 |    76.91 |    85.6 |   82.46 | ...,29558,29683,29763-29828,29951,30050,30267 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 0d7db7b into master Feb 8, 2021
@asturur asturur mentioned this pull request Apr 7, 2021
@asturur asturur deleted the image-scale-issue branch August 8, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resize filters work wrong, changing only scaleY (down) or scaleX (up) causes wrong ratio and undesired padding
1 participant