fix(): When the perPixelTargetFind is set to true, the selected transparent graphic cannot be moved #10445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parent graphic cannot be moved
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
asturur
reviewed
Feb 20, 2025
| @@ -820,7 +820,8 @@ export class SelectableCanvas<EventSpec extends CanvasEvents = CanvasEvents> | |||
| ) { | |||
| if ( | |||
| (this.perPixelTargetFind || obj.perPixelTargetFind) && | |||
| !(obj as unknown as IText).isEditing | |||
| !(obj as unknown as IText).isEditing && | |||
| this._activeObject != obj | |||
There was a problem hiding this comment.
We need to look at how this feature has been introduced/built before thinking is a bug and not a change of feature. I'll dig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a graphic is in the selected state, check its current position. Whether it is transparent or not should no longer be considered. I disabled this logic to ensure that transparent graphics can be operated normally
#10444