Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check surface device chrome 70 touch supports #5338

Closed
wants to merge 2 commits into from

Conversation

zhishaofei3
Copy link

@asturur
Copy link
Member

asturur commented Oct 27, 2018

#4302 <--- what about this?
We switched from one to the other 1 year ago.

@asturur
Copy link
Member

asturur commented Oct 27, 2018

also
maaaaark/bcSwipe#4

@asturur
Copy link
Member

asturur commented Oct 27, 2018

@tatsuyafw
Copy link

tatsuyafw commented Nov 2, 2018

@zhishaofei3

Any updates for this PR?
I've also faced the same problem when using a touch monitor.
(Ref: 898045 - Free drawing using a touch monitor shows nothing with fabric.js. - chromium - Monorail

@JSteunou
Copy link
Contributor

JSteunou commented Nov 9, 2018

I @asturur been a while :) We are also facing the same problem. Any chance to see this fix published?

@JSteunou
Copy link
Contributor

JSteunou commented Nov 9, 2018

I think previous fix #4302 was to aggressive. Chrome 70 comes with better touch support, so we need more fine grain now. This PR should be rewrite against source file, but the idea is good.

@asturur
Copy link
Member

asturur commented Nov 9, 2018

is just unclear to me if this is fixing because:

"ontouchstart" in fabric.document.documentElement

OR because the new condition is:

navigator.maxTouchPoints > 0

The original authour never answered.

@JSteunou
Copy link
Contributor

I will search about this monday. Ping me if I forget 😉

@asturur
Copy link
Member

asturur commented Nov 10, 2018

i ll undust my surface to see if i can also figure out

@asturur asturur closed this Nov 23, 2018
@JSteunou
Copy link
Contributor

👍

If someday this bug appears again, this can be a good resource https://patrickhlauke.github.io/touch/touchscreen-detection/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants