Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fabric.Text): fixes decoration rendering when there is a single rendering for the line #7104

Merged
merged 2 commits into from
Jun 6, 2021

Conversation

asturur
Copy link
Member

@asturur asturur commented Jun 6, 2021

fixes #7076

Make sure the last iteration of the loop is rtl aware too.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2021

Code Coverage Summary

> fabric@4.5.0 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.94 |    76.98 |   85.75 |   82.64 |                                               
 fabric.js |   82.94 |    76.98 |   85.75 |   82.64 | ...,29686,29811,29891-29956,30079,30178,30395 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit 74687fb into master Jun 6, 2021
@asturur asturur mentioned this pull request Jun 20, 2021
@asturur asturur deleted the rtl-decoration-fix branch August 8, 2021 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text decoration (undeline, linethrough) is wrong when direction is set to 'rtl' and align is not right
1 participant