Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text.class.js) added pathStartOffset and pathSide to props lists #7318

Merged
merged 6 commits into from
Aug 27, 2021

Conversation

melchiar
Copy link
Member

The new pathStartOffset and pathSide properties were missing from the toObject property list, the dimensionAffectingProps list, and the additionalProps list.

@melchiar melchiar changed the title fix(text.class.js) added pathStartOffset and pathSide to props lists in text.class.js fix(text.class.js) added pathStartOffset and pathSide to props lists Aug 21, 2021
src/shapes/text.class.js Outdated Show resolved Hide resolved
@asturur
Copy link
Member

asturur commented Aug 23, 2021

Fixing tests is a pain here

delete obj.path;
delete obj.pathStartOffset;
delete obj.pathSide;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we delete them?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well deleting them for now is ok is fine disregard this comment.

src/shapes/text.class.js Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2021

Code Coverage Summary

> fabric@4.5.1 coverage:report /home/runner/work/fabric.js/fabric.js
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.32 |    77.07 |   86.02 |   83.03 |                                               
 fabric.js |   83.32 |    77.07 |   86.02 |   83.03 | ...,29854,29979,30059-30124,30247,30346,30563 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur asturur merged commit c672744 into master Aug 27, 2021
@asturur asturur mentioned this pull request Aug 27, 2021
@asturur asturur deleted the textpath-fixprops branch February 4, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants