-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text.class.js) added pathStartOffset and pathSide to props lists #7318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
melchiar
changed the title
fix(text.class.js) added pathStartOffset and pathSide to props lists in text.class.js
fix(text.class.js) added pathStartOffset and pathSide to props lists
Aug 21, 2021
asturur
reviewed
Aug 23, 2021
Fixing tests is a pain here |
asturur
reviewed
Aug 25, 2021
src/shapes/text.class.js
Outdated
delete obj.path; | ||
delete obj.pathStartOffset; | ||
delete obj.pathSide; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why we delete them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well deleting them for now is ok is fine disregard this comment.
asturur
reviewed
Aug 25, 2021
asturur
approved these changes
Aug 27, 2021
Code Coverage Summary
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new pathStartOffset and pathSide properties were missing from the toObject property list, the dimensionAffectingProps list, and the additionalProps list.