Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): windows paths #7635

Merged
merged 18 commits into from
Feb 6, 2022
Merged

Conversation

ShaMan123
Copy link
Contributor

Fixed the annoying tests that failed because of path resolution.
I've changed tests to run on the basename of the path rather than the entire ugly path.

@ShaMan123 ShaMan123 requested a review from asturur January 26, 2022 23:33
@ShaMan123
Copy link
Contributor Author

ready

@asturur asturur merged commit d8ddf52 into fabricjs:master Feb 6, 2022
@asturur
Copy link
Member

asturur commented Feb 6, 2022

I think i gave up with windows development of JS immediately when i discovered fabricJS.
The tooling was automatic on linux and i just didn't bother.

@ShaMan123 ShaMan123 deleted the fix-tests-windows-paths branch February 6, 2022 08:35
@asturur asturur mentioned this pull request Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants