Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(blendimage_filter.class.js) corrected mode options #7672

Merged
merged 4 commits into from
Feb 13, 2022
Merged

Conversation

melchiar
Copy link
Member

Removed unsupported mode options for blendimage filter and added variable type

Removed unsupported mode options and added type
@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2022

Code Coverage Summary

> fabric@5.0.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    77.21 |   86.24 |   83.06 |                                               
 fabric.js |   83.33 |    77.21 |   86.24 |   83.06 | ...,30203,30328,30408-30473,30596,30695,30912 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2022

Code Coverage Summary

> fabric@5.0.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    77.23 |   86.24 |   83.06 |                                               
 fabric.js |   83.33 |    77.23 |   86.24 |   83.06 | ...,30209,30334,30414-30479,30602,30701,30918 
-----------|---------|----------|---------|---------|-----------------------------------------------

@melchiar
Copy link
Member Author

we really should have types indicated on all filter variables

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2022

Code Coverage Summary

> fabric@5.0.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    77.21 |   86.24 |   83.06 |                                               
 fabric.js |   83.33 |    77.21 |   86.24 |   83.06 | ...,30211,30336,30416-30481,30604,30703,30920 
-----------|---------|----------|---------|---------|-----------------------------------------------

@github-actions
Copy link
Contributor

github-actions bot commented Feb 12, 2022

Code Coverage Summary

> fabric@5.0.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    77.23 |   86.24 |   83.06 |                                               
 fabric.js |   83.33 |    77.23 |   86.24 |   83.06 | ...,30213,30338,30418-30483,30606,30705,30922 
-----------|---------|----------|---------|---------|-----------------------------------------------

@melchiar
Copy link
Member Author

melchiar commented Feb 12, 2022

@asturur we seem to be a bit inconsistent with our doc structure. Do you have a preferred structure for tagging property types?

@type String
or
@param {String}

@asturur
Copy link
Member

asturur commented Feb 13, 2022

would be nicer to implement them XD

@@ -66,8 +66,10 @@
mainParameter: 'matrix',

/**
* Lock the colormatrix on the color part, skipping alpha, manly for non webgl scenario
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping alpha manly.

image

@asturur asturur merged commit 76a5658 into master Feb 13, 2022
@asturur asturur mentioned this pull request Feb 15, 2022
@melchiar melchiar deleted the filter-docs branch July 2, 2022 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants