Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING chore(): Reuse fabric.Point logic for scaling and naming consistency #7710

Merged
merged 10 commits into from
Feb 20, 2022
Merged

BREAKING chore(): Reuse fabric.Point logic for scaling and naming consistency #7710

merged 10 commits into from
Feb 20, 2022

Conversation

ShaMan123
Copy link
Contributor

@ShaMan123 ShaMan123 commented Feb 19, 2022 •
edited
Loading

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.34 |    76.77 |   86.53 |   83.07 |                                               
 fabric.js |   83.34 |    76.77 |   86.53 |   83.07 | ...,29667,29792,29872-29937,30060,30159,30376 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 closed this Feb 19, 2022
@ShaMan123 ShaMan123 reopened this Feb 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 19, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.33 |    76.73 |   86.53 |   83.06 |                                               
 fabric.js |   83.33 |    76.73 |   86.53 |   83.06 | ...,29667,29792,29872-29937,30060,30159,30376 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Feb 19, 2022

This is good for me!
Where do we can start take note of breaking changes?

@asturur asturur changed the title chore(): Cleanup object scaling MAJOR chore(): Reuse fabric.Point logic for scaling and naming consistency Feb 19, 2022
@asturur asturur changed the title MAJOR chore(): Reuse fabric.Point logic for scaling and naming consistency MAJOR feat(): Reuse fabric.Point logic for scaling and naming consistency Feb 19, 2022
@ShaMan123
Copy link
Contributor Author

The CHANELOG?

@ShaMan123
Copy link
Contributor Author

I can draft one in a single PR after we merge these

@ShaMan123
Copy link
Contributor Author

npm bot

I see the action exists

asturur
asturur previously approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@asturur asturur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to remove the error throw from here too and then merge it if you want

@asturur
Copy link
Member

asturur commented Feb 20, 2022

there is a npm command now that helps a bit with the changelog.

Should we prepare the breaking changes v6 instructions on fabricjs.com while we make them and we are fresh? we can put the post public right away, is not a secret.

@ShaMan123
Copy link
Contributor Author

Good idea

@ShaMan123
Copy link
Contributor Author

It won't let me merge now because I've updated from master

@ShaMan123 ShaMan123 requested a review from asturur February 20, 2022 00:22
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   83.28 |    76.72 |   86.53 |   83.01 |                                               
 fabric.js |   83.28 |    76.72 |   86.53 |   83.01 | ...,29664,29789,29869-29934,30057,30156,30373 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 mentioned this pull request Feb 20, 2022
Closed
@ShaMan123
Copy link
Contributor Author

so in order to merge I simply run an update from master and then merge?
you said something about rebasing? Explain please

@ShaMan123 ShaMan123 merged commit 88b425c into master Feb 20, 2022
@ShaMan123 ShaMan123 deleted the cleanup-object-scaling branch February 20, 2022 12:24
@ShaMan123
Copy link
Contributor Author

@asturur look https://github.com/fabricjs/fabric.js/runs/5264461632?check_suite_focus=true

@ShaMan123 ShaMan123 mentioned this pull request Feb 21, 2022
Merged
ShaMan123 added a commit that referenced this pull request Mar 2, 2022
@ShaMan123
Squashed commit of the following:
dc335c1 
commit 109efe5
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Thu Feb 24 11:38:26 2022 +0200

    feat(util): transform utils (#7614)

    * Update misc.js

    * Update misc.js

    * rename

    * better JSDOC

    * Update misc.js

    * Update util.js

    * ci(): lint

    * better JSDOC

    * `sendObjectToPlane`

    * Update misc.js

    * Update util.js

    * Update util.js

    * Update misc.js

    * rename

    * Update misc.js

    * Update util.js

    * Update misc.js

    * remove redundant tests

    * Update util.js

    * Update misc.js

    * Update misc.js

    * Update util.js

    * Update util.js

    * fix(): reversed transform order

    * allow passing null for `sourceObject`

    * Update util.js

    * lint

    * Update misc.js

    * Update misc.js

    * ci: adjust tests to accept error

    * Update misc.js

    * Update util.js

    * build

    * Revert "Update misc.js"

    This reverts commit fb83a71.

    * Update misc.js

    * checkout

    * Update util.js

    * Update misc.js

    * Update util.js

    * typo

    * Update misc.js

    * optional parent

    * refactor around orphan objects

    * Update misc.js

    * add warning

    * Update object_geometry.mixin.js

    * lint

    * rename

    * JSDOC

    * Revert "JSDOC"

    This reverts commit a88b0ab.

    * remove unsafe `calcPlaneMatrix`

    * typo

    * Update misc.js

    * Update misc.js

commit 1d447b0
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Thu Feb 24 11:16:43 2022 +0200

    chore/fix(v6): prerequisites for Group (#7728)

commit f13075c
Author: Andrea Bogazzi <andreabogazzi79@gmail.com>
Date:   Thu Feb 24 10:03:22 2022 +0100

    tests() adding an extra controls test where the group are transformed (#7736)

commit bae062c
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Thu Feb 24 10:10:20 2022 +0200

    chore(): Group prerequisite minor refactor object_origin

commit 23ae1a7
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Wed Feb 23 00:43:36 2022 +0200

    fix(): ensure scaling factor is positive for strokeUniform (#7729)

    * Update object.class.js

    redundant else if

    * added a visual test

    * removed useless file

    * prefer dashes

    * prefer dashes

    * modified golden

    * more tolerance

    Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>

commit 84e405d
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Mon Feb 21 14:52:07 2022 +0200

    MAJOR chore(v6): neutral prerequisites for fabric.Group rework (#7726)

commit 0c98cee
Author: Andrea Bogazzi <andreabogazzi79@gmail.com>
Date:   Mon Feb 21 08:25:42 2022 +0100

    chore(): update CHANGELOG

commit 6565db1
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Mon Feb 21 07:30:19 2022 +0200

    fix(): add `eraser` to Object state/cache props (#7720)

    * Update eraser_brush.mixin.js

    * Update eraser_brush.mixin.js

commit fd1b0c3
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Sun Feb 20 17:18:19 2022 +0200

    feat(Object.isType): accept multiple `type` (#7715)

commit 4e80e77
Author: Andrea Bogazzi <andreabogazzi79@gmail.com>
Date:   Sun Feb 20 16:12:36 2022 +0100

    updated package.json

commit fc902cb
Author: CommanderRoot <CommanderRoot@users.noreply.github.com>
Date:   Sun Feb 20 13:40:29 2022 +0100

    chore(): Replace deprecated String.prototype.substr() with Array.prototype.slice() (#7696)

    String.prototype.substr() is deprecated (see https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substr) so we replace it with slice() which works similarily but isn't deprecated.
    Signed-off-by: Tobias Speicher <rootcommander@gmail.com>

commit 30c0c19
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Sun Feb 20 14:39:15 2022 +0200

    MAJOR feat(fabric.Point): divide, scalarDivide, scalarDivideEquals (#7716)

    * **BREAKING**: divide, scalarDivide, scalarDivideEquals

commit 2d922e1
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Sun Feb 20 14:37:52 2022 +0200

    chore(): use Array.isArray instead of ie6+ workarounds (#7718)

commit 88b425c
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Sun Feb 20 14:24:21 2022 +0200

    MAJOR feat(): Reuse fabric.Point logic for scaling and naming consistency (#7710)

    * fix(Object): object scaling inconsisteny

    **MAJOR**
     **BREAKING** `Object.getObjectScaling`, `Object.getTotalObjectScaling`

commit 7e563c7
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Sun Feb 20 02:19:13 2022 +0200

    chore(): BREAKING Cleanup fabric.Point for v6 (#7709)

    * Update misc.js

    * point **BREAKS** `multiply`

    * Update point.js

    * revert adding error check

commit 4c2e9a6
Author: Shachar <34343793+ShaMan123@users.noreply.github.com>
Date:   Sun Feb 20 01:52:47 2022 +0200

    tests(fabric.animation): fix test reliability
@ShaMan123 ShaMan123 changed the title MAJOR feat(): Reuse fabric.Point logic for scaling and naming consistency BREAKING chore(): Reuse fabric.Point logic for scaling and naming consistency Sep 20, 2022
@ShaMan123 ShaMan123 mentioned this pull request Sep 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur