You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaMan123
changed the title
chore(Textbox): expose methods for overrides
fix(Textbox): expose methods for overrides + fix resize filckering
Mar 15, 2022
This seems good, just give some explanation on why we are not using the offset information on the first pass of measuring.
If we do, then we don't need to remeasure later, we can use cached measures.
Or am i missing the point of that double loop?
(i think i because we want to know immediately which is the large word of all text before we take decisions on intermediate long words
I don't think a util should be overridden, that's why I've exposed graphemeSplit Renamed _measureWord to measureWord and made it public. Crucial for overrides and completes what I was after.
But is kind of BREAKING (the method was private so not so much)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first 2 methods are to make text more accessible from subclassing
graphemeSplit
on instancewordSplit
fixed line wrapping when word > width
BEFORE
FIXED