-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): move away from extend/clone #8001
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
|
ShaMan123
changed the title
chore(): move away from extend
chore(): move away from extend/clone
Jun 12, 2022
Code Coverage Summary
|
Code Coverage Summary
|
Code Coverage Summary
|
ShaMan123
commented
Jun 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a close look at src/gradient.class.js
tom make sure the cloning is really redundant
asturur
approved these changes
Jun 12, 2022
this is fine. I'll merge it now. |
Agreed.
I opened this to make the migration easier. Less complication
בתאריך יום א׳, 12 ביוני 2022, 15:00, מאת Andrea Bogazzi <
***@***.***>:
… Merged #8001 <#8001> into
master.
—
Reply to this email directly, view it on GitHub
<#8001 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIGAW4IDDYTTVZ3ZS6GV3CTVOXGMBANCNFSM5YRC4HOA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A semantic PR that replaces
fabric.util.object.extend
or the shallow version offabric.util.object.clone
withObject.assign
to prepare for the js/ts migration.I replaced relevant code after using the transformer (It uses extend as a search value).
The deep version of clone is used sparsely and in the future could be replaced by
lodash.cloneDeep
(~44KB vs. ~4KB oflang_object
😬). BTW I'm not sure it is really necessary in most cases.