ci(test): migrate test cmd #8138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
force fireworm resolution
Code Coverage Summary |
1 similar comment
Code Coverage Summary |
ShaMan123
commented
Aug 9, 2022
| @@ -77,10 +75,12 @@ | |||
| "commander": "^9.1.0", | |||
| "deep-object-diff": "^1.1.7", | |||
| "eslint": "^8.21.0", | |||
| "fireworm": "^0.7.2", | |||
There was a problem hiding this comment.
fixes testem ci error
There was a problem hiding this comment.
the error?
or the package?
There was a problem hiding this comment.
I forgot what was the error...
There was a problem hiding this comment.
no this package. How does it fix n error?
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
ShaMan123
commented
Aug 9, 2022
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
Code Coverage Summary |
1 similar comment
Code Coverage Summary |
Code Coverage Summary |
|
I would like the .fabric folder with test_results to be only test_results. I'm also trying to move the coverage report under the same command but it doesn't seem to work |
ShaMan123
commented
Aug 22, 2022
| @@ -53,6 +53,8 @@ | |||
| "export": "node ./scripts website export", | |||
| "build-tests": "rollup -c ./rollup.test.config.js", | |||
| "test": "node ./scripts test", | |||
| "test:unit-browser": "npm run test -- -s unit -p 8080 -l -c ", | |||
| "test:visual-browser": "npm run test -- -s visual -p 8080 -l -c ", | |||
There was a problem hiding this comment.
-c flag is already taken
There was a problem hiding this comment.
make it --coverage
There was a problem hiding this comment.
this is the -c flag to append chrome/firefox is not the coverage flag
There was a problem hiding this comment.
so -c chrome,firefox
|
I tried that and didn't get it to work |
ShaMan123
commented
Aug 22, 2022
| .addOption(new commander.Option('-c, --context <context...>', 'context to test in').choices(['chrome', 'firefox', 'node']).default(['chrome', 'node'])) | ||
| .option('-p, --port') | ||
| .option('-o, --out <out>', 'path to report test results to') | ||
| .option('--clear-cache', 'clear CLI test cache', false) |
There was a problem hiding this comment.
You should add the option --coverage here
There was a problem hiding this comment.
There was a problem hiding this comment.
karma has it....
https://www.npmjs.com/package/karma-coverage
There was a problem hiding this comment.
There was a problem hiding this comment.
I managed to get it to work only on node
is that enough?
There was a problem hiding this comment.
yes coverage needs only node, but results are weird in this screenshot.
There was a problem hiding this comment.
it's only for activeselection
|
i wasn't able to move the coverage command, i always get a command that hangs |
1 similar comment
|
i wasn't able to move the coverage command, i always get a command that hangs |
|
show you what i did diff --git a/scripts/index.js b/scripts/index.js
index 546e5ec7..e9802a20 100644
--- a/scripts/index.js
+++ b/scripts/index.js
@@ -148,7 +148,7 @@ function startWebsite() {
const args = ['run', 'start:dev'];
// WSL ubuntu
- // https://github.com/microsoft/WSL/issues/216
+ // https://github.com/microsoft/WSL/issues/216
// os.platform() === 'win32' && args.push('--', '--force_polling', '--livereload');
if (os.platform() === 'win32') {
console.log(chalk.green('Consider using ubuntu on WSL to run jekyll with the following options:'));
@@ -272,7 +272,7 @@ async function test(suite, tests, options = {}) {
env: {
...process.env,
TEST_FILES: (tests || []).join(','),
- NODE_CMD: ['qunit', 'test/node_test_setup.js', 'test/lib'].concat(tests || `test/${suite}`).join(' '),
+ NODE_CMD: [...(options.coverage ? ['nyc --silent']: []), 'qunit', 'test/node_test_setup.js', 'test/lib'].concat(tests || `test/${suite}`).join(' '),
VERBOSE: Number(options.verbose),
QUNIT_DEBUG_VISUAL_TESTS: Number(options.debug),
QUNIT_RECREATE_VISUAL_REFS: Number(options.recreate),
@@ -469,6 +469,7 @@ program
.option('-p, --port')
.option('-o, --out <out>', 'path to report test results to')
.option('--clear-cache', 'clear CLI test cache', false)
+ .option('-cov --coverage', 'Add coverage report with nyc', false)
.action((options) => {
if (options.clearCache) {
fs.removeSync(CLI_CACHE);
@@ -538,4 +539,4 @@ program
});
});
-program.parse(process.argv);
\ No newline at end of file
+program.parse(process.argv);i get a twst command that run super slow and make tests fail |
|
I did something pretty much the same. |
- .option('-cov --coverage', 'Add coverage report with nyc', false)
+ .option('-cov, --coverage', 'Add coverage report with nyc', false)
- ...(options.coverage ? ['nyc --silent']: [])
+ ...options.coverage ? 'nyc --silent': '' |
Code Coverage Summary |
Code Coverage Summary |
asturur
approved these changes
Aug 23, 2022
| @@ -77,10 +75,12 @@ | |||
| "commander": "^9.1.0", | |||
| "deep-object-diff": "^1.1.7", | |||
| "eslint": "^8.21.0", | |||
| "fireworm": "^0.7.2", | |||
There was a problem hiding this comment.
no this package. How does it fix n error?
frankrousseau
pushed a commit
to cgwire/fabric.js
that referenced
this pull request
Jan 6, 2023
Co-authored-by: Andrea Bogazzi <andreabogazzi79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
testcmd to usetestem.This is done so we can stop using
fabricjs.comfor local browser testing and discontinue any associations between the repos.I decided to keep going with
testemfor now.We can always migrate to
karmaif we want to.Later on we can remove the commands of the website...
or should I do that here and now?Should we move allDONEtestemfiles totests? I think it's better order. Their location is used only byscripts/indexFiles
workflows- semantic cmd changescripts/index- refactor to support testem + put all local cache files in.fabricfoldertest/GoldensServer.js- extract fromscripts/index, now runs when testem start visual teststestem*- adapted config/test page, moved undertestand refactored fromjsontojstest/lib/*- adapted methodsrollup.test.config.js- need help here, can't get the tests to build properlyLogging has become silly because the program spawns tests in parallel (node, chrome, firefox) so it logs a mess when
--verboseoption is set. Well actually it is not that bad because ci runs only one context at a time so there will be no parallel logging there. Only locally, so I think it is fine. The-c,--contextoption can be used to run a single context. So I can't care less about this. And the test results are dumped to separate files under.fabricso the dev can view it there nice and orderlyChanges
tests log only errors (exposed
--verboseflag)renamed
devcmd tofabricWhat about the rest of the interactive tests on fabricjs.com?
Started another effort migrating benchmarks, will PR in the near future