Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(TS): ElementsParser => parser/ElementsParser #8183

Merged
merged 4 commits into from
Aug 26, 2022
Merged

chore(TS): ElementsParser => parser/ElementsParser #8183

merged 4 commits into from
Aug 26, 2022

Conversation

ShaMan123
Copy link
Contributor

move under parser and update some imports

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.09 |    74.54 |   84.45 |   80.68 |                                               
 fabric.js |   82.09 |    74.54 |   84.45 |   80.68 | ...,27452,27510,27520-27564,27672,27759,27963 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 mentioned this pull request Aug 25, 2022
Merged
asturur
asturur reviewed Aug 25, 2022
View reviewed changes
src/parser/elements_parser.ts

fabric.ElementsParser = function(elements, callback, options, reviver, parsingOptions, doc) {
import { fabric } from "../../HEADER";
import { capitalize, invertTransform, multiplyTransformMatrices, qrDecompose } from "../util";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please import them from respective files if migrated. I want to remove that generic util barrel import.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.14 |    74.57 |   84.45 |   80.74 |                                               
 fabric.js |   82.14 |    74.57 |   84.45 |   80.74 | ...,27452,27510,27520-27564,27672,27759,27963 
-----------|---------|----------|---------|---------|-----------------------------------------------

@ShaMan123 ShaMan123 changed the title chore(TS): ElementsParser chore(TS): ElementsParser => parser/ElementsParser Aug 25, 2022
ShaMan123 added a commit that referenced this pull request Aug 26, 2022
@ShaMan123
dep(): fabric.console (#8184)
c4a2946 
#8183 removes the last remaining usage
@github-actions
Copy link
Contributor

github-actions bot commented Aug 26, 2022 •
edited
Loading

Code Coverage Summary

> fabric@5.1.0 coverage:report
> nyc report --reporter=lcov --reporter=text

-----------|---------|----------|---------|---------|-----------------------------------------------
File       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s                             
-----------|---------|----------|---------|---------|-----------------------------------------------
All files  |   82.13 |    74.65 |   84.34 |   80.74 |                                               
 fabric.js |   82.13 |    74.65 |   84.34 |   80.74 | ...-27672,27788-27789,27810-27851,27866-28025 
-----------|---------|----------|---------|---------|-----------------------------------------------

@asturur
Copy link
Member

asturur commented Aug 26, 2022

i m going to make a pr to remove that util/index.ts

@asturur asturur merged commit 1f72fb7 into master Aug 26, 2022
@ShaMan123 ShaMan123 deleted the chore-parser branch September 11, 2022 23:36
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
@ShaMan123 @frankrousseau
dep(): fabric.console (fabricjs#8184)
6461d09 
fabricjs#8183 removes the last remaining usage
frankrousseau pushed a commit to cgwire/fabric.js that referenced this pull request Jan 6, 2023
@ShaMan123 @frankrousseau
chore(TS): ElementsParser => parser/ElementsParser (fabricjs#8183)
1153f4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asturur asturur asturur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShaMan123 @asturur