-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(TS): EventSpec recognition #8497
Conversation
OMG what a nightmare A time sink microsoft/TypeScript#32080
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should consider making FabricObjectSVGExportMixin
a mixer function like collection and drop applyMixins
I need this merged
cacheCanvasEl: HTMLCanvasElement; | ||
protected _isCurrentlyDrawing: boolean; | ||
freeDrawingBrush: BaseBrush; | ||
_activeObject: FabricObject; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of there belong to canvas along with drawControls
and _applyCanvasStyle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So how this passed before withtout the ts-nocheck on top?
How did i get a clea build without those types?
Well i think there is a balance between everyhing magically typed and type safety. |
It was because of the return type of collection mixin that was any |
Motivation
Description
This PR fixes the recognition of the EventSpec generic type that was lost by Group.
Emphasizes the for #8394
Disclaimer: TS has taken a toll from me in this inane effort. Nothing good to say about it today.
Changes
Gist
In Action