-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(test): Textbox fromObject test #8686
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this test was causing a lot of problems it took me a lot of time to understand what is wrong So because we spread the input arg in `Text.fromObject` passing instance to `fromObject` pollutes the created instance with class props I don't think we should care about it, though it is an edge case. No sense in passing a live instance to `fromObject` but if you think differently then we can safeguard it by running `cloneDeep` before spreading
Build Stats
|
ShaMan123
commented
Feb 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@melchiar can you shed some light on this test?
asturur
approved these changes
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This test is blocking me while working on features and makes me think my fixes are buggy
You asked for scoped PRs so here it is.
Blocking control set fix.
Description
this test was causing a lot of problems
it took me a lot of time to understand what was wrong
because we spread the input arg in
Text.fromObject
passing instance tofromObject
pollutes the created instance with class props that are enumerable strangly. This might be a node/QUnit thing.I don't think we should care about it, though it is an edge case.
No sense in passing a live instance to
fromObject
but if you think differently then we can safeguard it by runningcloneDeep
before spreading itChanges
Gist
In Action