-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS) remove controls from prototype #8753
Conversation
Build Stats
|
@ShaMan123 probably we can go up to having a different control object per instance, since a way to rollback with few lines of code is still possible ( if the developer desire so ). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great.
I didn't expect this pivot from you.
I want simple code and options. |
I want to add that logic that was adapted to shared controls (e.g. control visibility, passing down the object that uses the control etc.) might be thought of as obsolete. |
And we can make the controls object a class holding more methods such as setting visibility |
Motivation
Controls are the last part of the data we have on the protoype.
This pr removes them and put them in the defaults.
Controls are still shared between instances because of javascript mutability of objects.