-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(): Path remove unused code from path render function #9619
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Build Stats
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking
Why don't we have a ref of Path2D to save on iterations?
Currently this runs every render cycles if caching is invalidated
yes Path2D was an optimization we skipped because not supported by all browsers, but it was planned long ago, like when issues had 3 numbers. |
Description
Those let variables were a leftover from the old rendering code when we supported in render all type of path commands.
After the path semplification logic ( moving all commands to absolutes L, M, C, Q, Z ) the carry over of those values is not needed.
In Action