Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unstyled packages #157

Merged
merged 15 commits into from
Feb 4, 2025
Merged

Add unstyled packages #157

merged 15 commits into from
Feb 4, 2025

Conversation

IzumiSy
Copy link
Member

@IzumiSy IzumiSy commented Jan 25, 2025

This PR adds a new component registry that contains unstyled components for Fabrix.

Currently, fabrix has only one component package (chakra-ui), but that's a bit confusing to see how fabrix itself work without UIs. Introducing unstyled components would be more helpful to see the behaviour without component concerns.

Purpose of the changes

  • I am planning to add some working examples on docs that can be switched between styled and unstyled components to see that our package is pluggable in the frontend.
  • As regads to demo purpose, I am observing that using UI component library on Stackblitz causes unavoidable wait in its up-time (almost 3-5 secs) when I use Vite because of bundling the package. That does not happen when I don't use any third-party UI packges, so I would like use unstyled package for our demo on Stackblitz as well for better experience.
  • Unstyled package can be a good example to know what's needed in creating custom component registry.

Screenshot

スクリーンショット 2025-02-01 12 29 39

@IzumiSy IzumiSy self-assigned this Jan 25, 2025
Copy link

changeset-bot bot commented Jan 25, 2025

🦋 Changeset detected

Latest commit: 46d44ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fabrix-framework/unstyled Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@IzumiSy IzumiSy force-pushed the add_unstyled_components branch from 5e3048d to e413cec Compare January 25, 2025 11:44
@IzumiSy IzumiSy changed the title Initial commit Add unstyled packages Jan 25, 2025
Copy link

pkg-pr-new bot commented Jan 25, 2025

Open in Stackblitz

npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/chakra-ui@157
npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/fabrix@157
npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/unstyled@157
npm i https://pkg.pr.new/fabrix-framework/fabrix/@fabrix-framework/graphql-config@157

commit: 46d44ea

@IzumiSy IzumiSy force-pushed the add_unstyled_components branch from ea15b70 to 35d1528 Compare January 31, 2025 09:55
@IzumiSy IzumiSy marked this pull request as ready for review February 1, 2025 03:25
@IzumiSy IzumiSy requested a review from a team as a code owner February 1, 2025 03:25
@toiroakr
Copy link
Contributor

toiroakr commented Feb 3, 2025

I think there was also an option to set as default fallback, but is there a specific reason you chose to publish as package instead?

@IzumiSy
Copy link
Member Author

IzumiSy commented Feb 3, 2025

@toiroakr

I think there was also an option to set as default fallback, but is there a specific reason you chose to publish as package instead?

Actually, we don't have any default fallback now, so we can make this package the one for fallback in that sense.

And, the reasons why I added this package as the separated one are:

  • I expect unstyled pacakage to be a good example to start creating custom components. To know fully about the dependencies and strcuture without distraction, I would like to make this package explicit and independent. If unstyled package is a part of the core package, that is a bit too complex to grasp the main concern to start creating the component registry from scratch.

  • Unstyled package is expected to be used as the demonstration purpose. The application in the real world would not use unstyled package, but it will use the hand-crafted custom components or other built-in packages like fabrix-framework/chakra-ui instead.

@IzumiSy IzumiSy merged commit 6a7bb01 into main Feb 4, 2025
5 checks passed
@IzumiSy IzumiSy deleted the add_unstyled_components branch February 4, 2025 06:09
This was referenced Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants