Remove @fabrix-framework/fabrix/rhf export #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IzumiSy
commented
Oct 10, 2024
| @@ -37,7 +33,8 @@ | |||
| "peerDependencies": { | |||
| "graphql": "^16", | |||
| "react": "^18", | |||
| "react-dom": "^18" | |||
| "react-dom": "^18", | |||
| "react-hook-form": "^7" | |||
IzumiSy
force-pushed
the
remove_rhf_package
branch
from
2d951b7 to
738dba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fabrix internally uses react-hook-form to manage form states and was exposing
@fabrix-framework/fabrix/rhfto provider users with the same version of react-hook-form. This is a adhoc workaround toward the behaviour thatuseControllerhook in component registries does not access the same version of react-hook-form that fabrix internally mounts asFormProvider.However, I found that adding react-hook-form a peer dependency also works out. Exposing RHF from fabrix was a bit clumsy, so this PR is a fix for that.