Fix sending queued reports on Laravel Vapor queues #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlexVanderbist this seems to have caused #401 Had to revert to 2.11.0 due to errors on horizon |
|
✅ ported to spatie/laravel-ignition https://github.com/spatie/laravel-ignition/blob/0e98bd0cacdae5a2b0d2e7f2bf3ecc7f0356dd9f/src/IgnitionServiceProvider.php#L282-L293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laravel Vapor processes queued jobs one by one without firing the
Loopingevent in between jobs. Vapor also doesn't call PHP's registered shutdown functions (on the queue lambda at least). Exceptions thrown in Vapor jobs will not get reported because of these two issues.The solution is to use both the queue
beforeandafterevents.Beforewill send any pending reports (from a before the queued job) and make sure the dump/log/query recorders are emptied before executing the queued job.Afterwill report any exceptions thrown during job execution.Because we're using both
beforeandafter, there's some overlap but as this only causes some internal arrays to be emptied twice, this can be ignored.