Skip to content

Commit

Permalink
Take out error about HSS not being supported with batch trials (#2709)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #2709

Context:

This error seems to be wrong. This seems to be supported, and we can't think why it wouldn't be.

Reviewed By: saitcakmak

Differential Revision: D61737790

fbshipit-source-id: 639310ac2adad758715b36d9ff667f7150f2330d
  • Loading branch information
esantorella authored and facebook-github-bot committed Aug 24, 2024
1 parent 9010f43 commit 003983d
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions ax/core/experiment.py
Original file line number Diff line number Diff line change
Expand Up @@ -1499,15 +1499,6 @@ def attach_trial(
# Create the trial and add arm(s)
trial = None
if is_batch:
# TODO: HSS support for batch trials.
if self.search_space.is_hierarchical:
raise NotImplementedError(
"Support for batch trials "
"in hierarchical search space coming soon. Let "
"the Ax developers know if you have a use "
"case for it."
)

trial = self.new_batch_trial(
ttl_seconds=ttl_seconds, optimize_for_power=optimize_for_power
).add_arms_and_weights(arms=arms)
Expand Down

0 comments on commit 003983d

Please sign in to comment.