Make evaluation metadata accept iso formatted dates instead of ints in ms #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D42050451 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D42050451 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 20, 2022
…n ms (facebook#1334) Summary: Pull Request resolved: facebook#1334 Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data Differential Revision: D42050451 fbshipit-source-id: ef853ae8e5d42ef489cadd66ac6af5d36efdba15
danielcohenlive
force-pushed
the
export-D42050451
branch
from
8f980e3
to
43aae7b
Compare
Codecov ReportBase: 94.66% // Head: 94.66% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 420 420
Lines 38485 38526 +41
=======================================
+ Hits 36430 36471 +41
Misses 2055 2055
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 21, 2022
…n ms (facebook#1334) Summary: Pull Request resolved: facebook#1334 Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data Differential Revision: D42050451 fbshipit-source-id: 0bc5328dd64afe648e459c381856109a467195ef
danielcohenlive
force-pushed
the
export-D42050451
branch
from
43aae7b
to
02eafd2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42050451 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 21, 2022
…n ms (facebook#1334) Summary: Pull Request resolved: facebook#1334 Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data Differential Revision: D42050451 fbshipit-source-id: 1c52446c15d2900f3f5829fe72d05d1ab953210d
danielcohenlive
force-pushed
the
export-D42050451
branch
from
02eafd2
to
b099cb8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42050451 |
…ts in ms (facebook#1334) Summary: Pull Request resolved: facebook#1334 Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data Also fix interpretation of ints in ms in `Data.from_evaluations()` Differential Revision: D42050451 fbshipit-source-id: 17bfdb0f5725b5bff2e883f0f3ed303a975fc95c
danielcohenlive
force-pushed
the
export-D42050451
branch
from
b099cb8
to
eb154f4
Compare
|
This pull request was exported from Phabricator. Differential Revision: D42050451 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 21, 2022
…n ms (facebook#1334) Summary: Pull Request resolved: facebook#1334 Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data Differential Revision: https://internalfb.com/D42050451 fbshipit-source-id: 7f4a0fd488337dadd8ee452241364402af077405
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Dec 22, 2022
…n ms (facebook#1334) Summary: Pull Request resolved: facebook#1334 Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data Differential Revision: https://internalfb.com/D42050451 fbshipit-source-id: 7ad8713c399d0bea81cab7eaa4a4233191e6c142
|
This pull request has been merged in c6c67d8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Because ints in ms don't work with pd.Timestamp, which the models ultimately need (https://fburl.com/code/ci5ji3kr) and which render in data
Differential Revision: D42050451