Use transition_to to move GS forward #1986
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51264471 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 14, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Differential Revision: D51264471
mgarrard
force-pushed
the
export-D51264471
branch
from
acece6c to
f953a75
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51264471 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1986 +/- ##
==========================================
+ Coverage 94.52% 94.53% +0.01%
==========================================
Files 460 460
Lines 44301 44311 +10
==========================================
+ Hits 41874 41890 +16
+ Misses 2427 2421 -6 ☔ View full report in Codecov by Sentry. |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 15, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Differential Revision: D51264471
mgarrard
force-pushed
the
export-D51264471
branch
from
f953a75 to
71b0464
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51264471 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 15, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Differential Revision: D51264471
mgarrard
force-pushed
the
export-D51264471
branch
from
71b0464 to
b3fc59f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51264471 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 17, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 18, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
force-pushed
the
export-D51264471
branch
from
b3fc59f to
fd59070
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51264471 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 18, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 18, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 18, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
force-pushed
the
export-D51264471
branch
from
fd59070 to
7049196
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51264471 |
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 27, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 27, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Nov 27, 2023
Summary: This diff does the following: (0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node upcoming: (0) remove need for all genstep functions -- generator run limit, etc (1) delete functions from GenStep that aren't needed anymore (2) update the storage to include nodes independently (and not just as part of step) (3) final pass on all the doc strings (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion Reviewed By: lena-kashtelyan Differential Revision: D51264471
|
This pull request has been merged in f8560e8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff does the following:
(0) actually uses should_transition_to_next at GenerationStrategy level & use transition_to argument to determine the next node
upcoming:
(0) remove need for all genstep functions -- generator run limit, etc
(1) delete functions from GenStep that aren't needed anymore
(2) update the storage to include nodes independently (and not just as part of step)
(3) final pass on all the doc strings
(4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode
(5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed
(6) rename transiton criterion to action criterion
Differential Revision: D51264471