Adding parameter "baseline_arm_name" to "_format_comparison_string" #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51589439 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2016 +/- ##
==========================================
- Coverage 94.53% 94.53% -0.01%
==========================================
Files 460 460
Lines 44311 44310 -1
==========================================
- Hits 41891 41890 -1
Misses 2420 2420 ☔ View full report in Codecov by Sentry. |
mgrange1998
force-pushed
the
export-D51589439
branch
from
f4eecda to
40a7c88
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51589439 |
mgrange1998
pushed a commit
to mgrange1998/Ax
that referenced
this pull request
Nov 27, 2023
…acebook#2016) Summary: Updating _format_comparison_string to take baseline_arm_name as parameter, replacing the behavior of hardcoding baseline_arm_name using BASELINE_ARM_NAME. Reviewed By: bernardbeckerman Differential Revision: D51589439
mgrange1998
force-pushed
the
export-D51589439
branch
from
40a7c88 to
048935f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51589439 |
…acebook#2016) Summary: Updating _format_comparison_string to take baseline_arm_name as parameter, replacing the behavior of hardcoding baseline_arm_name using BASELINE_ARM_NAME. Reviewed By: bernardbeckerman Differential Revision: D51589439
mgrange1998
force-pushed
the
export-D51589439
branch
from
048935f to
e550154
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51589439 |
|
This pull request has been merged in 46052a1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D51589439