Accept any GSInterface for database updates #2034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51677487 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 30, 2023
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 30, 2023
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
added 2 commits
November 30, 2023 15:31
Summary: Mainly this means implementing `gen_multiple_with_ensembling()` Reviewed By: lena-kashtelyan Differential Revision: D51306927
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 30, 2023
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 30, 2023
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
danielcohenlive
force-pushed
the
export-D51677487
branch
from
54359fd to
c3d405d
Compare
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 30, 2023
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
danielcohenlive
force-pushed
the
export-D51677487
branch
from
c3d405d to
5550118
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51677487 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51677487 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 30, 2023
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though Reviewed By: lena-kashtelyan Differential Revision: D51677487
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2034 +/- ##
==========================================
+ Coverage 94.47% 94.51% +0.04%
==========================================
Files 460 460
Lines 44349 44410 +61
==========================================
+ Hits 41898 41974 +76
+ Misses 2451 2436 -15 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in a31074a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In preparation for D51307866, accept and handle any tpye of GSInterface in save and update methods. Only standard GSs will be saved though
Reviewed By: lena-kashtelyan
Differential Revision: D51677487