Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add output_tasks to MTGP in MBM #2241

Closed
wants to merge 1 commit into from
Closed

add output_tasks to MTGP in MBM #2241

wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

@sdaulton sdaulton commented Mar 2, 2024

Summary: see title. output_tasks were not set for MTGP in MBM.

Differential Revision: D54453253

@facebook-github-bot facebook-github-bot added CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported labels Mar 2, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54453253

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 87.50000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 94.86%. Comparing base (5893365) to head (107d913).

❗ Current head 107d913 differs from pull request most recent head 8a9da38. Consider uploading reports for the commit 8a9da38 to get more accurate results

Files Patch % Lines
ax/models/torch/botorch_modular/surrogate.py 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2241      +/-   ##
==========================================
- Coverage   94.86%   94.86%   -0.01%     
==========================================
  Files         467      467              
  Lines       46433    46441       +8     
==========================================
+ Hits        44047    44054       +7     
- Misses       2386     2387       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Mar 4, 2024
@sdaulton @facebook-github-bot
add output_tasks to MTGP in MBM (facebook#2241)
c27a5f8 
Summary:

see title. output_tasks were not set for MTGP in MBM.

Differential Revision: D54453253
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54453253

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Mar 4, 2024
@sdaulton @facebook-github-bot
add output_tasks to MTGP in MBM (facebook#2241)
500ce66 
Summary:

see title. output_tasks were not set for MTGP in MBM.

Differential Revision: D54453253
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54453253

sdaulton added a commit to sdaulton/Ax-1 that referenced this pull request Mar 4, 2024
@sdaulton @facebook-github-bot
add output_tasks to MTGP in MBM (facebook#2241)
79ee045 
Summary:

see title. output_tasks were not set for MTGP in MBM.

Differential Revision: D54453253
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54453253

@sdaulton @facebook-github-bot
add output_tasks to MTGP in MBM (facebook#2241)
39aa987 
Summary:

see title. output_tasks were not set for MTGP in MBM.

Differential Revision: D54453253
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54453253

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in fbb59a3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdaulton @facebook-github-bot @codecov-commenter