Light cleanup of GenerationStrategyInterface
#2256
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51441575 |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 7, 2024
Summary: Key changes: 1. bring back to GS aspects of GSI that are not needed there and are polluting the interface, 2. make `_name` a required attribute of both GSI and GS. Re: 2), having it be set during the first call to `name` property was causing weird bugs in equality checks, there two GSs looked like they were equal but they weren't at the time of the initial equality check (one had the `_name` set because its `name` prop was called, and another did not yet). They would become equal during the call to `__repr__` that occurred in reporting their inequality as an error (!), because `__repr__` would call `GS.name`, which would result in `GS._name` getting set. Weird stuff! Reviewed By: danielcohenlive, mgarrard Differential Revision: D51441575
lena-kashtelyan
force-pushed
the
export-D51441575
branch
from
7d4d89c to
1290067
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51441575 |
Summary: Key changes: 1. bring back to GS aspects of GSI that are not needed there and are polluting the interface, 2. make `_name` a required attribute of both GSI and GS. Re: 2), having it be set during the first call to `name` property was causing weird bugs in equality checks, there two GSs looked like they were equal but they weren't at the time of the initial equality check (one had the `_name` set because its `name` prop was called, and another did not yet). They would become equal during the call to `__repr__` that occurred in reporting their inequality as an error (!), because `__repr__` would call `GS.name`, which would result in `GS._name` getting set. Weird stuff! Reviewed By: danielcohenlive, mgarrard Differential Revision: D51441575
lena-kashtelyan
force-pushed
the
export-D51441575
branch
from
1290067 to
4c3106c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51441575 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2256 +/- ##
==========================================
- Coverage 94.86% 94.84% -0.02%
==========================================
Files 467 467
Lines 46478 46489 +11
==========================================
+ Hits 44090 44094 +4
- Misses 2388 2395 +7 ☔ View full report in Codecov by Sentry. |
lena-kashtelyan
pushed a commit
to lena-kashtelyan/Ax
that referenced
this pull request
Mar 8, 2024
Summary: Key changes: 1. bring back to GS aspects of GSI that are not needed there and are polluting the interface, 2. make `_name` a required attribute of both GSI and GS. Re: 2), having it be set during the first call to `name` property was causing weird bugs in equality checks, there two GSs looked like they were equal but they weren't at the time of the initial equality check (one had the `_name` set because its `name` prop was called, and another did not yet). They would become equal during the call to `__repr__` that occurred in reporting their inequality as an error (!), because `__repr__` would call `GS.name`, which would result in `GS._name` getting set. Weird stuff! Reviewed By: danielcohenlive, mgarrard Differential Revision: D51441575
|
This pull request has been merged in c7dadf4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Key changes:
_namea required attribute of both GSI and GS.Re: 2), having it be set during the first call to
nameproperty was causing weird bugs in equality checks, there two GSs looked like they were equal but they weren't at the time of the initial equality check (one had the_nameset because itsnameprop was called, and another did not yet). They would become equal during the call to__repr__that occurred in reporting their inequality as an error (!), because__repr__would callGS.name, which would result inGS._namegetting set. Weird stuff!Reviewed By: danielcohenlive, mgarrard
Differential Revision: D51441575