Handle errors in score trace computations #2263
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D54702411 |
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2263 +/- ##
==========================================
+ Coverage 94.86% 94.87% +0.01%
==========================================
Files 469 469
Lines 46545 46558 +13
==========================================
+ Hits 44156 44173 +17
+ Misses 2389 2385 -4 ☔ View full report in Codecov by Sentry. |
Summary: This part of the code errors out if benchmarks are ran with a non-tranditional GS, such as one that uses GNodes rather than GSteps. Simply handling the error and skipping the score computation to unblock ad-hoc benchmarking in the short term. We can re-visit this once we start using generation nodes in nightly benchmarks. Reviewed By: esantorella Differential Revision: D54702411
saitcakmak
force-pushed
the
export-D54702411
branch
from
cf993b8
to
adf02bd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D54702411 |
|
This pull request has been merged in 800357a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This part of the code errors out if benchmarks are ran with a non-tranditional GS, such as one that uses GNodes rather than GSteps. Simply handling the error and skipping the score computation to unblock ad-hoc benchmarking in the short term. We can re-visit this once we start using generation nodes in nightly benchmarks.
Differential Revision: D54702411