Fix flaky test for sensitivity analysis #2268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This fixes a flaky test for sensitivity analysis. Currently the QMC integration done for computing Sobol indices is seeded for reproducibility. That done for computing derivative-based sensitivity measures is not. This diff changes that so that the derivative-based measures will also have seeded QMC with the same seed, to match Sobol indices. A side effect of this is that it fixes the flaky test, since the results are no longer random based on the QMC points. Reviewed By: bernardbeckerman Differential Revision: D54855136
|
This pull request was exported from Phabricator. Differential Revision: D54855136 |
facebook-github-bot
added
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2268 +/- ##
=======================================
Coverage 94.89% 94.90%
=======================================
Files 481 481
Lines 47057 47061 +4
=======================================
+ Hits 44656 44662 +6
+ Misses 2401 2399 -2 ☔ View full report in Codecov by Sentry. |
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This fixes a flaky test for sensitivity analysis. Currently the QMC
integration done for computing Sobol indices is seeded for reproducibility.
That done for computing derivative-based sensitivity measures is not. This diff
changes that so that the derivative-based measures will also have seeded QMC
with the same seed, to match Sobol indices.
A side effect of this is that it fixes the flaky test, since the results are no
longer random based on the QMC points.
Reviewed By: bernardbeckerman
Differential Revision: D54855136