Reap deprecated argument transform_outcomes_and_configs in get_pareto_frontier_and_configs
#2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eto_frontier_and_configs` Summary: This was deprecated in v0.2.9 in facebook#1200. On the usual deprecation schedule, it should only be removed on 4.0.0, while we're only at 0.3.7. However, I think this is fine to remove now since the change is almost a year and a half old. `get_pareto_frontier_and_configs` is spitting out an annoying warning about the default behavior changing even when this parameter is not passed; that could in theory be removed on its own, with the argument reaped later, but I don't think it justifies a second PR. Reviewed By: lena-kashtelyan Differential Revision: D54902341
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54902341 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2274 +/- ##
==========================================
- Coverage 94.90% 94.90% -0.01%
==========================================
Files 481 481
Lines 47068 47054 -14
==========================================
- Hits 44669 44655 -14
Misses 2399 2399 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in c6282a4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This was deprecated in v0.2.9 in #1200. On the usual deprecation schedule, it should only be removed on 4.0.0, while we're only at 0.3.7. However, I think this is fine to remove now since the change is almost a year and a half old.
get_pareto_frontier_and_configsis spitting out an annoying warning about the default behavior changing even when this parameter is not passed; that could in theory be removed on its own, with the argument reaped later, but I don't think it justifies a second PR.Reviewed By: lena-kashtelyan
Differential Revision: D54902341