Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doc strings on TransitionCriterion to improve usability #2278

Closed
wants to merge 1 commit into from
Closed

Update doc strings on TransitionCriterion to improve usability #2278

wants to merge 1 commit into from

Conversation

sdaulton
Copy link
Contributor

Summary: Sait pointed out recently that the doc strings on transition criterion could be improved, this diff does so

Reviewed By: Balandat

Differential Revision: D54914622

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 14, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54914622

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.89%. Comparing base (953eab4) to head (9646c01).

❗ Current head 9646c01 differs from pull request most recent head 7d8daac. Consider uploading reports for the commit 7d8daac to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2278      +/-   ##
==========================================
- Coverage   94.90%   94.89%   -0.02%     
==========================================
  Files         481      481              
  Lines       47053    47029      -24     
==========================================
- Hits        44654    44626      -28     
- Misses       2399     2403       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sdaulton pushed a commit to sdaulton/Ax-1 that referenced this pull request Mar 14, 2024
@mgarrard @facebook-github-bot
Update doc strings on TransitionCriterion to improve usability (faceb…
7d8daac 
…ook#2278)

Summary:

Sait pointed out recently that the doc strings on transition criterion could be improved, this diff does so

Reviewed By: Balandat

Differential Revision: D54914622
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54914622

sdaulton pushed a commit to sdaulton/Ax-1 that referenced this pull request Mar 15, 2024
@mgarrard @facebook-github-bot
Update doc strings on TransitionCriterion to improve usability (faceb…
4052a8e 
…ook#2278)

Summary:

Sait pointed out recently that the doc strings on transition criterion could be improved, this diff does so

Reviewed By: Balandat

Differential Revision: D54914622
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54914622

sdaulton pushed a commit to sdaulton/Ax-1 that referenced this pull request Mar 21, 2024
@mgarrard @facebook-github-bot
Update doc strings on TransitionCriterion to improve usability (faceb…
88d9ce0 
…ook#2278)

Summary:

Sait pointed out recently that the doc strings on transition criterion could be improved, this diff does so

Reviewed By: Balandat

Differential Revision: D54914622
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54914622

@mgarrard mgarrard closed this Mar 21, 2024
@mgarrard mgarrard reopened this Mar 22, 2024
@mgarrard @facebook-github-bot
Update doc strings on TransitionCriterion to improve usability (faceb…
906b39e 
…ook#2278)

Summary:

Sait pointed out recently that the doc strings on transition criterion could be improved, this diff does so

Reviewed By: Balandat

Differential Revision: D54914622
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54914622

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 35642c1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdaulton @facebook-github-bot @codecov-commenter @mgarrard