Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test #2282

Closed
wants to merge 1 commit into from
Closed

Conversation

mgarrard
Copy link
Contributor

Summary:
X-link: facebookresearch/aepsych#338

Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node.

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54960088

Summary:

X-link: facebookresearch/aepsych#338

Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. 

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088
crasanders pushed a commit to crasanders/aepsych that referenced this pull request Mar 18, 2024
Summary:
X-link: facebook/Ax#2282


Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node. 

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54960088

facebook-github-bot pushed a commit to facebookresearch/aepsych that referenced this pull request Mar 18, 2024
Summary:
X-link: facebook/Ax#2282

Pull Request resolved: #338

Previously the integration test was failing due to not allowing unlimited trials on the last step. This is because the final step was copied from the exisiting botorch step (which contains transition criterion). If transition criterion exist on the step/node, we default to using those for determining the state of the node.

This fixes the test by manually unsetting the transition criterion arg for the aepsych strategy.py.

We also re-enable the test

Reviewed By: crasanders

Differential Revision: D54960088

fbshipit-source-id: e9c61f5ddefe45f5a9824c6dbd9068989a03bf72
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 23636ed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants