Allow customizing num_init_trials in MBM benchmark method #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54690298 |
|
This pull request was exported from Phabricator. Differential Revision: D54690298 |
saitcakmak
force-pushed
the
export-D54690298
branch
from
ac8cf5a
to
85dc407
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2286 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 489 489
Lines 47581 47583 +2
=======================================
+ Hits 45156 45158 +2
Misses 2425 2425 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 564cedb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This is useful for benchmarking high parallelism setting, where we typically want all of the first batch to be Sobol.
Also makes use of the previously ignored name kwarg.
Reviewed By: esantorella
Differential Revision: D54690298