Allow for passing model_gen_kwargs in benchmarks #2336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55844014 |
Summary: - Add scheduler options for running benchmarks with BatchTrial - Append "_batch" to the name of MBM batched Reviewed By: Balandat Differential Revision: D55750921
Summary: Pull Request resolved: facebook#2335 Reviewed By: sdaulton Differential Revision: D55875116
Summary: This makes it easier to test changing defaults. Reviewed By: sdaulton Differential Revision: D55844014
esantorella
force-pushed
the
export-D55844014
branch
from
a449ab6
to
9f0ba9e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55844014 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2336 +/- ##
==========================================
- Coverage 94.91% 94.90% -0.01%
==========================================
Files 491 491
Lines 47788 47819 +31
==========================================
+ Hits 45356 45385 +29
- Misses 2432 2434 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 1f837a3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This makes it easier to test changing defaults.
Reviewed By: sdaulton
Differential Revision: D55844014