Make objective direction checks more strict #2382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56315542 |
saitcakmak
force-pushed
the
export-D56315542
branch
from
904fbeb
to
0f23b82
Compare
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 19, 2024
Summary: With this change, at least one of `minimize` or `lower_is_better` must be specified. If both are specified, they must match. Added a json storage helper & updated SQA storage helpers for deserializing previously saved objectives in a backwards compatible manner, resolving the conflicts in favor of `minimize`. Differential Revision: D56315542
|
This pull request was exported from Phabricator. Differential Revision: D56315542 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 19, 2024
Summary: With this change, at least one of `minimize` or `lower_is_better` must be specified. If both are specified, they must match. Added a json storage helper & updated SQA storage helpers for deserializing previously saved objectives in a backwards compatible manner, resolving the conflicts in favor of `minimize`. Differential Revision: D56315542
saitcakmak
force-pushed
the
export-D56315542
branch
from
0f23b82
to
12f9984
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56315542 |
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Apr 19, 2024
Summary: With this change, at least one of `minimize` or `lower_is_better` must be specified. If both are specified, they must match. Added a json storage helper & updated SQA storage helpers for deserializing previously saved objectives in a backwards compatible manner, resolving the conflicts in favor of `minimize`. Differential Revision: D56315542
saitcakmak
force-pushed
the
export-D56315542
branch
from
12f9984
to
ecac750
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56315542 |
Summary: With this change, at least one of `minimize` or `lower_is_better` must be specified. If both are specified, they must match. Added a json storage helper & updated SQA storage helpers for deserializing previously saved objectives in a backwards compatible manner, resolving the conflicts in favor of `minimize`. Differential Revision: D56315542
saitcakmak
force-pushed
the
export-D56315542
branch
from
ecac750
to
d8c55df
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56315542 |
|
This pull request has been merged in 853b340. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: With this change, at least one of
minimizeorlower_is_bettermust be specified. If both are specified, they must match.Differential Revision: D56315542