Do not transform search space in-place in Modelbridge._get_transformed_gen_args #2386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56400492 |
…d_gen_args (facebook#2386) Summary: Pull Request resolved: facebook#2386 The current setup leads to issues when calling `evaluate_acquisition_function()` in between generation steps, see discussion on facebook#2083 Reviewed By: saitcakmak Differential Revision: D56400492
Balandat
force-pushed
the
export-D56400492
branch
from
83e970c
to
54840a0
Compare
|
This pull request has been merged in 6c55c0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The current setup leads to issues when calling
evaluate_acquisition_function()in between generation steps, see discussion on #2083Differential Revision: D56400492