Update tests so that data contains metric_names that are on the corresponding experiments #2422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2422 +/- ##
=======================================
Coverage 95.30% 95.31%
=======================================
Files 497 497
Lines 48526 48536 +10
=======================================
+ Hits 46250 46260 +10
Misses 2276 2276 ☔ View full report in Codecov by Sentry. |
bernardbeckerman
force-pushed
the
export-D56850033
branch
from
13b1a41 to
123f3bf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56850033 |
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
force-pushed
the
export-D56850033
branch
from
123f3bf to
e349206
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56850033 |
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 6, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 7, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
bernardbeckerman
added a commit
to bernardbeckerman/Ax
that referenced
this pull request
May 7, 2024
…sponding experiments (facebook#2422) Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue. Reviewed By: saitcakmak Differential Revision: D56850033
|
This pull request has been merged in 28aaff1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: In D56634321, observations_from_dataframe fails if there are metric_names Data.df that don't also exist on the experiment. This adjusts tests so that they avoid this issue.
Differential Revision: D56850033