Have MBM only pass acqf input constructor kwargs to BoTorch when they are not None #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57387912 |
facebook-github-bot
added
CLA Signed
esantorella
added a commit
to esantorella/Ax
that referenced
this pull request
May 29, 2024
… are not None (facebook#2480) Summary: Currently, Ax passes a lot of arguments that are not used and BoTorch ignores them. In the future, this will throw an exception rather than being ignored. Reviewed By: Balandat Differential Revision: D57387912
esantorella
force-pushed
the
export-D57387912
branch
from
3cf93e3
to
d4b0251
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57387912 |
… are not None (facebook#2480) Summary: Currently, Ax passes a lot of arguments that are not used and BoTorch ignores them. In the future, this will throw an exception rather than being ignored. Reviewed By: Balandat Differential Revision: D57387912
esantorella
force-pushed
the
export-D57387912
branch
from
d4b0251
to
4d35e2c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57387912 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
- Coverage 95.28% 95.27% -0.01%
==========================================
Files 485 485
Lines 47408 47406 -2
==========================================
- Hits 45171 45168 -3
- Misses 2237 2238 +1 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 0dce67c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Currently, Ax passes a lot of arguments that are not used and BoTorch ignores them. In the future, this will throw an exception rather than being ignored.
Differential Revision: D57387912