Remove unused suppress_all_errors kwarg #2491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Audited usage of `suppress_all_errors` and removed the ignored kwarg (which was using the attribute set at the class level). Also added a comment on use cases where it appears to be unused, while actually getting consumed by the decorator. Reviewed By: dme65, Balandat Differential Revision: D58042565
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58042565 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2491 +/- ##
==========================================
- Coverage 95.28% 95.27% -0.01%
==========================================
Files 485 485
Lines 47400 47400
==========================================
- Hits 45163 45161 -2
- Misses 2237 2239 +2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 13e3378. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Audited usage of
suppress_all_errorsand removed the ignored kwarg (which was using the attribute set at the class level). Also added a comment on use cases where it appears to be unused, while actually getting consumed by the decorator.Reviewed By: dme65, Balandat
Differential Revision: D58042565