Update np.Inf -> np.inf per numpy 2.0 release #2527
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Numpy 2.0 was released yesterday ([post](https://numpy.org/news/#numpy-20-release-date-june-16)) and accordingly a couple of tests started breaking due to usage of a now-outdated API. This updates references to the now-deprecated `np.Inf` to `np.inf`, which is available in both old and new versions of numpy and so shouldn't create any issues. Our early-stopping tutorial is still breaking due to a similar issue in TensorBoard (tensorflow/tensorboard#6869), so not all tests are expected to pass as of now. Differential Revision: D58672474
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D58672474 |
|
This pull request has been merged in ae28cb1. |
This was referenced Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Numpy 2.0 was released yesterday (post) and accordingly a couple of tests started breaking due to usage of a now-outdated API. This updates references to the now-deprecated
np.Inftonp.inf, which is available in both old and new versions of numpy and so shouldn't create any issues.Our early-stopping tutorial is still breaking due to a similar issue in TensorBoard (tensorflow/tensorboard#6869), so not all tests are expected to pass as of now.
Differential Revision: D58672474